Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3551
This PR migrates
submitted_jobsbackground task to pipelines. The main behavioral change is that old task locked all project's instances before selecting fleets and held the lock during the entire instance assignment duration that includes long get offers calls. Now the fleet is selected without instance lock and instance lock is only acquired for the chosen fleet to select existing instance offer, which is quick. Otherwise it's mostly one-to-one migration with pipeline specifics such separate processing/apply phases.Known
submitted_jobsissues like #3665, #3663, #3603 are NOT fixed. I decided to fix them for pipelines only after dropping scheduled tasks altogether since they require changes across background tasks.